Operator retry test fix attempt #2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 5, 2015 23:36
| @@ -227,9 +227,9 @@ public void awaitTerminalEvent() { | |||
| * @throws RuntimeException | |||
| * if the Subscriber is interrupted before the Observable is able to complete | |||
| */ | |||
| public void awaitTerminalEvent(long timeout, TimeUnit unit) { | |||
| public boolean awaitTerminalEvent(long timeout, TimeUnit unit) { | |||
There was a problem hiding this comment.
Any suggestion how I can sneak out the await's result?
There was a problem hiding this comment.
Throw TimeoutException? It's a bit minor breaking change. @benjchristensen Is it fine?
There was a problem hiding this comment.
I've changed it back and made it throw a RTE with TimeoutException as cause.
This was referenced Jan 29, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe the error function was not emitting events properly.