SubscribeOn/ObserveOn Implementation #199
Conversation
|
RxJava-pull-requests #39 FAILURE |
|
.NET implementation of a Scheduler interface contains methods like Schedule<TState>(TState, Func<IScheduler, TState, IDisposable>) To be honest, I don't quite understand why it is designed to use |
|
RxJava-pull-requests #40 FAILURE |
|
This is great stuff @mairbek, thank you! This one is going to result in a lot of discussion so won't be pulled in right away and will likely involve some changes. For example, a discussion is being kicked off with Erik Meijer (inventor of Rx at Microsoft) to clarify some design decisions on this. |
|
@sgudiboina if you can join in on the review of this it would be helpful. @mairbek Erik himself has stated on Twitter that RxJava needs Schedulers so this is definitely high priority! Anyone else with time to get involved please do. The design of Schedulers will have long-lasting impact so we want to get it as close to right as possible now. |
|
Anyone getting involved please review #19 for context. |
|
|
||
| import static org.mockito.Mockito.*; | ||
|
|
||
| public class CurrentThreadScheduler extends AbstractScheduler { |
There was a problem hiding this comment.
This took me a bit to grok but I think I got it and I believe it matches how Rx describes it:
The CurrentThreadScheduler (by accessing the static CurrentThread property) will schedule actions to be performed on the thread that makes the original call. The action is not executed immediately, but is placed in a queue and only executed after the current action is complete.
http://msdn.microsoft.com/en-us/library/hh242963(v=vs.103).aspx
This example also helped me: http://www.introtorx.com/content/v1.0.10621.0/15_SchedulingAndThreading.html#Current
It looks like you might have gotten the unit test from there ... so I think this behaves correctly if I'm understanding it right.
From what I can tell this scheduler is useful when doing nested calls (like the repeat operator) to be a "trampoline" and allow recursion without overflowing the stack ... correct?
|
@mairbek This is great work, thank you for the research and thought you obviously did for this and the clean and well-written code. I've posted my questions and comments via the inline code mechanism so they are contextual. |
|
RxJava-pull-requests #71 FAILURE |
ExecutorScheduler throws exception for the delayed action.
|
RxJava-pull-requests #74 FAILURE |
|
This request can no longer be automatically merged so I have manually merged it and done some further work on top of your commits at #225. Please review what I've done. If possible I'd like to merge and release within the next 24 hours. I'm closing this request since all of your commits are now contained on #225. Great work @mairbek I appreciate you taking this on. |
Schedulers (merge of pull #199)
Schedulers (merge of pull ReactiveX#199)
Initial suggestion for a feign <-> resilience4j module
Implementation SubscribeOn #11 and ObserveOn #12 alongside with basic Schedulers implementation #19.