Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE when the key is null in GroupBy #1966

Merged
merged 1 commit into from
Dec 13, 2014
Merged

Fix NPE when the key is null in GroupBy #1966

merged 1 commit into from
Dec 13, 2014

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Dec 12, 2014

Fix the issue that when the key is null, groupby will throw NPE.

@zsxwing zsxwing mentioned this pull request Dec 12, 2014
Closed
@benjchristensen
Copy link
Member

Aren't null keys fun? :-)

Thanks @zsxwing

benjchristensen added a commit that referenced this pull request Dec 13, 2014
@benjchristensen
Merge pull request #1966 from zsxwing/fix-groupby-null-key
29e764a 
Fix NPE when the key is null in GroupBy
@benjchristensen benjchristensen merged commit 29e764a into ReactiveX:1.x Dec 13, 2014
@zsxwing zsxwing deleted the fix-groupby-null-key branch December 14, 2014 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zsxwing @benjchristensen