Add "Subscriptions.unsubscribed" to fix the 'isUnsubscribed' issue #1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,7 +26,7 @@ | |||
| */ | |||
| public final class MultipleAssignmentSubscription implements Subscription { | |||
| /** The shared empty state. */ | |||
| static final State EMPTY_STATE = new State(false, Subscriptions.empty()); | |||
| static final State EMPTY_STATE = new State(false, Subscriptions.unsubscribed()); | |||
There was a problem hiding this comment.
Why does this one start as unsubscribed?
There was a problem hiding this comment.
Subscriptions.unsubscribed() will be returned to the user when MultipleAssignmentSubscription is unsubscribed.
There was a problem hiding this comment.
I was wrong. It should be Subscriptions.empty.
|
Looks good. Just want to understand the one question I asked. |
…criptions.empty()
zsxwing
force-pushed
the
unsubscribed
branch
from
0db4fd6
to
35f2807
Compare
|
Now the static EMPTY_STATE can not be used because it becomes stateful. |
benjchristensen
added a commit
that referenced
this pull request
Dec 13, 2014
Add "Subscriptions.unsubscribed" to fix the 'isUnsubscribed' issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #1943