Add pointer regarding unit tests as inner classes #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #31 SUCCESS |
|
Turns out that indentation with long lines doesn't look nice in text files (esp. when rendered by GitHub), so I've converted this README to Markdown just like most/all other text files in this project (hope it hasn't been like so intentionally). |
|
RxJava-pull-requests #32 SUCCESS |
|
Hi @sopel, thanks for submitting this, you're right that it's better to make it clear why this choice was made. Ben |
benjchristensen
added a commit
that referenced
this pull request
Mar 15, 2013
Add pointer regarding unit tests as inner classes
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
Add pointer regarding unit tests as inner classes
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
* ReactiveX#186 Feature: circuitBreaker reset * Revert "ReactiveX#186 Feature: circuitBreaker reset" This reverts commit 651dec6b176d52f1cdd3bdf32d7da34c81f80e2c. * ReactiveX#159 added new states, missing tests * ReactiveX#159 adding states missed add ReactiveX#159 adding states part 2 * ReactiveX#159 changes in names Changing method names, removing unnecessary events and listeners * ReactiveX#159 Testing State, Metrics and Event Publishing. Added mechanism for Event and State publishing check * ReactiveX#159 reverting gradle files committed as an error * ReactiveX#159 fixed CR from codacy * ReactiveX#159 fixed CR duplication from codacy * ReactiveX#159 started adding some ascii doc, fixed a missing Event in factory * ReactiveX#159 fixing/cleaning test * ReactiveX#159 Adding some documentation * ReactiveX#159 Adding some documentation * ReactiveX#159 CR changes * 159 Adding metrics in FORCED_CLOSED state
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@benjchristensen - If I hadn't stumbled over your respective pointer by chance, I would have asked the same question as Matt Bishop when encountering this README.
Your reasoning for embedding unit tests as inner classes is inspiring (thanks much) and a helpful explanation for those who disagree regardless, so I suggest to promote it accordingly.