Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beta & Experimental Annotations #1905

Merged
merged 1 commit into from
Nov 29, 2014
Merged

Beta & Experimental Annotations #1905

merged 1 commit into from
Nov 29, 2014
+92 −0

Conversation

benjchristensen
Copy link
Member

See #1824

@benjchristensen benjchristensen mentioned this pull request Nov 29, 2014
Closed
@benjchristensen
Copy link
Member Author

I chose rx.annotations but am open to suggestions for a better package name. It could perhaps be rx.lifecycle. I don't want rx.util or rx.common. We worked hard to eliminate those catch-all packages.

@daschl
Copy link
Contributor

daschl commented Nov 29, 2014

+1 on annotations

@benjchristensen
Copy link
Member Author

Thanks for voting on this so it's not just me!

@benjchristensen benjchristensen mentioned this pull request Nov 29, 2014
Closed
@akarnokd
Copy link
Member

rx.annotations is okay with me as well.

@benjchristensen
Copy link
Member Author

I'm merging this then so we can start using it on some of the other PRs.

Thanks @daschl and @akarnokd for the review.

benjchristensen added a commit that referenced this pull request Nov 29, 2014
@benjchristensen
Merge pull request #1905 from benjchristensen/lifecycle-annotations
eb8254e 
Beta & Experimental Annotations
@benjchristensen benjchristensen merged commit eb8254e into ReactiveX:1.x Nov 29, 2014
@benjchristensen benjchristensen deleted the lifecycle-annotations branch November 29, 2014 21:44
@benjchristensen benjchristensen mentioned this pull request Dec 2, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjchristensen @daschl @akarnokd