Operator GroupBy Pull Request - Review and Refactor #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
RxJava-pull-requests #18 SUCCESS |
|
The only thing I don't like right now about this is having GroupedObservable in the rx.* package. It feels like an implementation detail that should live in a sub-package rather than the top-most package. For example, in Rx.Net I'm wondering if we should have rx.observables similar to rx.subscriptions (#173). Observable belongs at rx.Observable (and maybe the rx.Subscription interface as well) but all other impls should be in a sub-package I think. |
benjchristensen
added a commit
that referenced
this pull request
Mar 12, 2013
Operator GroupBy Pull Request - Review and Refactor
|
RxJava-pull-requests #19 SUCCESS |
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
Operator GroupBy Pull Request - Review and Refactor
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored version of pull request #176 for issue #51
I would like to avoid delegation if possible since it will mean it needs to be kept in sync with Observable.
This refactored approach allows inheritance without delegation by composing the Observable inside another operator function.