OnSubscribeRefCount with Synchronous Support #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional tests on top of those started by @davidmoten
|
@davidmoten @akarnokd Are you okay with this? Are there missing unit tests from #1753 (comment) that we need to fix and get in here? |
|
I'm looking at them right now and trying to figure out why they don't work. |
|
I think the reason is this -> #1753 (comment) |
|
Figured out why the other was failing so merging this now. |
benjchristensen
added a commit
that referenced
this pull request
Oct 15, 2014
OnSubscribeRefCount with Synchronous Support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #1753 with fixes to unit tests.
Fixes #1688