Fix NPE when iterable is null #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ha. There sure is :-) |
|
Thanks. I agree with this change. Does anyone disagree? |
|
The question is, do we apply this kind of parameter checks everywhere else? Rx.NET does this all the time. |
|
What other places need it? Many places null is valid. Let's put the checks where they should exist and we are missing them. |
benjchristensen
added a commit
that referenced
this pull request
Oct 13, 2014
Fix NPE when iterable is null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #1676, I prefer that throwing an NullPointerException in the constructor of
OnSubscribeFromIterable.BTW, because https://github.com/ReactiveX/RxJava/blob/v1.0.0-rc.5/src/main/java/rx/internal/operators/OnSubscribeFromIterable.java#L43 does not return after
o.onCompleted();, there is still a NPE bug here.