Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dematerialize #174

Closed
wants to merge 5 commits into from
Closed

Conversation

prabirshrestha
Copy link
Contributor

PR for #37

Someone might want to help me with proper unit tests :)

@cloudbees-pull-request-builder

test-RxJava-pull-requests #2 FAILURE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder

RxJava-pull-requests #9 SUCCESS
This pull request looks good

@mairbek
Copy link
Contributor

mairbek commented Mar 9, 2013

I would suggest you to use Mockito for the unit tests instead of coding stub observer. This will make testing a lot more easier.

Basically what you need is to mock observer using Mockito#mock method (Observer<Integer> aObserver = mock(Observer.class);) and than verify calls to the mock object using verify method, for example verify(aObserver, times(1)).onNext(1);

Mockito is widely used within the codebase so you might want take a look to the existing tests for examples.

@prabirshrestha
Copy link
Contributor Author

@mairbek thanks. updated the code to use mockit. but still use observable.materialize()

@cloudbees-pull-request-builder

RxJava-pull-requests #10 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder

test-RxJava-pull-requests #3 FAILURE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder

RxJava-pull-requests #11 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder

test-RxJava-pull-requests #4 FAILURE
Looks like there's a problem with this pull request

@benjchristensen
Copy link
Member

This could not be automatically merged due to conflicts with other pull requests so manually merged in #177

jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
…miter-configuration

ReactiveX#174 Dynamic ratelimiter configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants