ObserveOn Error Propagation #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make code easier to understand with some refactoring of the pollQueue loop - add a unit test to ensure correct behavior with a hot Observable source
- errors were not being propagated if backpressure was exerted (requested==0) - terminal events do not need to be requested so it now ignores the requested count to emit onError
benjchristensen
added a commit
that referenced
this pull request
Oct 6, 2014
ObserveOn Error Propagation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onError was not being propagated if the child subscriber was backpressured (requested==0)
This fixes the second bug mentioned in #1717