ObserveOn Error Handling #1683
Merged
ObserveOn Error Handling #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should delegate the toString to the Exception, not reach into the message. Some Exceptions don't have a message so this could print "null" and not show the exception type.
The queue will be drained to find and emit the onError.
... and doesn't allow intermittent onNext via a race of draining the queue and emitting (the draining thread must be where the skipping happens, not the producer thread).
|
LGTM |
| if (!on.accept(child, o)) { | ||
| // non-terminal event so let's increment count | ||
| emitted++; | ||
| if (failure) { |
There was a problem hiding this comment.
Conceptually a better way of doing this is for line 145 above to clear the queue and add just the single error.
There wasn't an obvious way to do in a thread-safe manner when I wrote this code ... but we can definitely improve to enable that.
benjchristensen
added a commit
that referenced
this pull request
Oct 2, 2014
ObserveOn Error Handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution for #1681 and #1680