Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operator Scan Backpressure Fix #1648

Merged
merged 3 commits into from
Aug 31, 2014
Merged

Operator Scan Backpressure Fix #1648

merged 3 commits into from
Aug 31, 2014

Commits on Aug 31, 2014

  1. Operator Scan Backpressure Fix 

    Problem 1) The initial value was being emitted before subscription which caused issues with request/producer state, particularly if filter() was used to skip that initial value and then called request(1) before the real request had been sent.
Problem 2) The initial value was not accounted for by the request so it was sending 1 more value than requested. It now modifies the request to account for it.
Problem 3) Redo relied upon these nuances to work. I've fixed this by using a simpler implementation that just maintains state within a map function.
    @benjchristensen
    benjchristensen committed Aug 31, 2014
    Configuration menu
    Copy the full SHA
    11a8d39 View commit details
    Browse the repository at this point in the history

  2. Update RxSwing use of Scan 

    The initial value is sent when first onNext is sent, not at subscription time.
    @benjchristensen
    benjchristensen committed Aug 31, 2014
    Configuration menu
    Copy the full SHA
    ac75ded View commit details
    Browse the repository at this point in the history

  3. Skip the empty Set being emitted 

    This is unnecessary and unexpected so skipping it.
    @benjchristensen
    benjchristensen committed Aug 31, 2014
    Configuration menu
    Copy the full SHA
    4787adf View commit details
    Browse the repository at this point in the history