Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operators to create Observables from BroadcastReceiver (rebased) #1528

Merged
merged 4 commits into from
Jul 29, 2014

Conversation

Yarikx
Copy link
Contributor

@Yarikx Yarikx commented Jul 29, 2014

Rebase #1449 on the top of #1524

Add test for OperatorBroadcastRegister

@cloudbees-pull-request-builder

RxJava-pull-requests #1449 FAILURE
Looks like there's a problem with this pull request

@dpsm
Copy link
Contributor

dpsm commented Jul 29, 2014

LGTM

@benjchristensen
Copy link
Member

@mttkay Are you also ready for this to merge?

@mttkay
Copy link
Contributor

mttkay commented Jul 29, 2014

👍

@benjchristensen
Copy link
Member

Thanks.

benjchristensen added a commit that referenced this pull request Jul 29, 2014
Add operators to create Observables from BroadcastReceiver (rebased)
@benjchristensen benjchristensen merged commit 27a56dc into ReactiveX:master Jul 29, 2014
@benjchristensen
Copy link
Member

Are you okay with this only being released in 0.20, or do you need it back-ported to 0.19?

Have any of you tried 0.20.0-RC3 on Android and confirmed whether it is okay? ==> #1517

@mttkay
Copy link
Contributor

mttkay commented Jul 29, 2014

I bumped out beta channel version to 0.20.0.RC-3 today, it will go out
tomorrow to our beta users. I passed all our testing so far, so definitely
nothing major to report. The issues we had were mostly due to race
conditions (which got fixed now) which is quite difficult to reproduce in
automated or even manual testing, so I'll have to wait for logging to
trickle in from the beta release.

@benjchristensen
Copy link
Member

Good to know it's passing initial tests. That means the major code paths like merge and observeOn are okay on Android and I didn't make any fundamental mistakes in the sun.misc.Unsafe gates.

There are definitely still some bugs that have been found and fixed but not yet released. Hopefully tomorrow I'll release RC4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants