Variety of Fixes #1380
Merged
Variety of Fixes #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A rewrite of TakeUntil that doesn't leak NotificationLite.COMPLETE outside of itself. It causes problems to leak the sentinels as other operators also using NotificationLite get confused.
This could cause an unwanted unsubscribe to be propagate because of the `SafeSubscriber`
Remove the null check and lazy creation, build the queue in the ThreadLocal. Fix bugs about "work in progress".
|
RxJava-pull-requests #1318 SUCCESS |
|
Nice catches. |
| @@ -150,6 +150,12 @@ public void assertUnsubscribed() { | |||
| } | |||
| } | |||
|
|
|||
| public void assertNoErrors() { | |||
| if (getOnErrorEvents().size() > 0) { | |||
| throw new AssertionError("Unexpected onError events: " + getOnErrorEvents().size(), getOnErrorEvents().get(0)); | |||
There was a problem hiding this comment.
public AssertionError(String message, Throwable cause) is a java7 api.
There was a problem hiding this comment.
Well that's just silly ... thanks for the catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... found while working on backpressure.