Fix the bug that BlockingObservable.singleOrDefault doesn't call unsubscribe #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #1156 SUCCESS |
| throw new IllegalArgumentException("Sequence contains too many elements"); | ||
| } | ||
| return result; | ||
| return from(o.map(Functions.<T>identity()).singleOrDefault(defaultValue)).single(); |
There was a problem hiding this comment.
Why do you need to map with the identity function here?
There was a problem hiding this comment.
Because o is Observable<? extends T> and I cannot call singleOrDefault(T) on it directly.
There was a problem hiding this comment.
Does that mean that XXXOrDefault have to be covariant as well :-(
public T singleOrDefault(T defaultValue)
There was a problem hiding this comment.
Observable<T> singleOrDefault(T defaultValue) also need to
However, I cannot write <U super T> Observable<U> singleOrDefault(U defaultValue) in Java :(
There was a problem hiding this comment.
This covariance stuff is insane.
There was a problem hiding this comment.
benjchristensen
added a commit
that referenced
this pull request
May 27, 2014
Merge pull request #1260
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlockingObservable.singleOrDefaultdoesn't callunsubscribewhen throwsIllegalArgumentException("Sequence contains too many elements").testSingleOrDefaultUnsubscribeproves this bug.