Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix to remove drift from schedulePeriodic #1162

Merged
merged 1 commit into from
May 6, 2014
Merged

fix to remove drift from schedulePeriodic #1162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions rxjava-core/src/main/java/rx/Scheduler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,15 +99,16 @@ public abstract static class Worker implements Subscription {
*/
public Subscription schedulePeriodically(final Action0 action, long initialDelay, long period, TimeUnit unit) {
final long periodInNanos = unit.toNanos(period);
final long startInNanos = TimeUnit.MILLISECONDS.toNanos(now()) + unit.toNanos(initialDelay);

final Action0 recursiveAction = new Action0() {
long count = 0;
@Override
public void call() {
if (!isUnsubscribed()) {
long startedAt = now();
action.call();
long timeTakenByActionInNanos = TimeUnit.MILLISECONDS.toNanos(now() - startedAt);
schedule(this, periodInNanos - timeTakenByActionInNanos, TimeUnit.NANOSECONDS);
long nextTick = startInNanos + (++count * periodInNanos);
schedule(this, nextTick - TimeUnit.MILLISECONDS.toNanos(now()), TimeUnit.NANOSECONDS);
}
}
};
Expand Down