Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observable: abstract or final #7

Closed
benjchristensen opened this issue Jan 16, 2013 · 3 comments
Closed

Observable: abstract or final #7

benjchristensen opened this issue Jan 16, 2013 · 3 comments
Labels
Question
Milestone
0.5

Comments

@benjchristensen
Copy link
Member

There is discussion about whether Observable should be a "final class" and only be usable via Observable.create(Func) or whether we should leave it as abstract.

Discuss and decide ...
@abersnaze
Copy link
Contributor

I vote not final.
If it were final then it would be impossible to extend Observable to add operators and still interoperate with other code that uses Observable.

@benjchristensen
Copy link
Member Author

Agreed

@benjchristensen
Copy link
Member Author

We have decided to not make it final.

But we also have changed it from being abstract to a normal concrete class.

The 'subscribe' implementation is passed in via a protected constructor or using Observable.create(Func1)

benjchristensen added a commit that referenced this issue Feb 14, 2014
@benjchristensen
Merge pull request #7 from zsxwing/subscribeOn+groupBy
6863f57 
Add timeout to CoundDownLatch, ignore InterruptException and fix the tes...
@RuanJH RuanJH mentioned this issue Aug 13, 2019
Closed
jihoonson pushed a commit to jihoonson/RxJava that referenced this issue Mar 6, 2020
@storozhukBM @RobWin
Issue ReactiveX#7 RingBitSet optimisation
7b282af 
* test coverage added + jacoco excludes for benchmark classes

* Issue ReactiveX#7 RingBitSet optimisation + benchmark results

* Issue ReactiveX#7 cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Question
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
2 participants
@abersnaze @benjchristensen