You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While working on a fix for #577 I've run into a test failure (happened randomly):
org.mockito.exceptions.verification.VerificationInOrderFailure:
Verification in order failure
Wanted but not invoked:
observer.onCompleted();
-> at rx.operators.OperationConcatTest.testNestedAsyncConcat(OperationConcatTest.java:259)
Wanted anywhere AFTER following interaction:
observer.onNext("nine");
-> at rx.operators.SafeObserver.onNext(SafeObserver.java:121)
at rx.operators.OperationConcatTest.testNestedAsyncConcat(OperationConcatTest.java:259)
It appears the observer.onCompleted() in L195 races with the test inOrder.verify(observer, times(1)).onCompleted(); on L259. Adding a latch after L195 and before L259 seems to be a way to fix this, but I'm not sure of whether this is rather an issue with concat (I see plenty of questionable things in there too).
Thoughts?
The text was updated successfully, but these errors were encountered:
…er are ca… (ReactiveX#594)
* Issue ReactiveX#581: Some RxJava2 or Reactor operators like ZipObserver are cancelling (disposing) a second Observable when the first observable is complete. This is because an operator like zip must combine two events. It makes no sense to consume further events of the second observable when the first is completed. Unfortunately the cancellation is bad for the CircuitBreakerOperator, since no success is recorded even if an emit was emitted successfully. Solution: The CircuitBreaker operator and BulkHead operator could track if an event has been emitted successfully (onNext). And when dispose/cancel is invoked, the operator either invokes onSuccess/onComplete or releasePermission.
While working on a fix for #577 I've run into a test failure (happened randomly):
It appears the
observer.onCompleted()
in L195 races with the testinOrder.verify(observer, times(1)).onCompleted();
on L259. Adding a latch after L195 and before L259 seems to be a way to fix this, but I'm not sure of whether this is rather an issue withconcat
(I see plenty of questionable things in there too).Thoughts?
The text was updated successfully, but these errors were encountered: