Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRLF issues :-( #579

Closed
headinthebox opened this issue Dec 8, 2013 · 2 comments
Closed

CRLF issues :-( #579

headinthebox opened this issue Dec 8, 2013 · 2 comments

Comments

@headinthebox
Copy link
Contributor

Cannot believe that it is 2013 and we are still having CRLF changes

I guess that @akarnokd is using Windows and I have trouble with CRLF in Async.java and friends.
@akarnokd
Copy link
Member

akarnokd commented Dec 8, 2013

Yes, I'm on Windows and using NetBeans 7.4 with default git settings. I thought all this line ending is automatically managed by github or the repo as specified here.

So the question is, should I create a PR with fixed CRLF or will this be handled on the repo level?

@akarnokd akarnokd mentioned this issue Dec 8, 2013
Closed
@benjchristensen
Copy link
Member

I'll play with those Github settings to see if I can resolve it there.

benjchristensen added a commit that referenced this issue Dec 8, 2013
@benjchristensen
GitAttributes for Line Endings
4782588 
https://help.github.com/articles/dealing-with-line-endings

See #579
rickbw pushed a commit to rickbw/RxJava that referenced this issue Jan 9, 2014
@benjchristensen
GitAttributes for Line Endings
eae31cb 
https://help.github.com/articles/dealing-with-line-endings

See ReactiveX#579
rickbw pushed a commit to rickbw/RxJava that referenced this issue Jan 9, 2014
@benjchristensen
Normalize Line Endings
c2cd326 
See https://help.github.com/articles/dealing-with-line-endings#re-normalizing-a-repository
Fixes ReactiveX#579
jihoonson pushed a commit to jihoonson/RxJava that referenced this issue Mar 6, 2020
@RobWin
Issue ReactiveX#559: Support of @CIRCUITBREAKER annotation along with…
1f0e62f 
… @FeignClient (ReactiveX#579)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benjchristensen @headinthebox @akarnokd