Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator: Finally #43

Closed
benjchristensen opened this issue Jan 18, 2013 · 3 comments
Closed

Operator: Finally #43

benjchristensen opened this issue Jan 18, 2013 · 3 comments
Milestone

Comments

@benjchristensen
Copy link
Member

http://msdn.microsoft.com/en-us/library/hh212133(v=vs.103).aspx

abliss added a commit to abliss/RxJava that referenced this issue Mar 17, 2013
@mattrjacobs
Copy link
Contributor

@abliss Pull Request #196 was manually merged via @joshgord's Pull Request #222. @joshgord is working on unit tests of Exceptions getting thrown by operation in finally block. Once that's done, this issue will be closed.

@joshgord
Copy link

joshgord commented Apr 3, 2013

Here is the test case @mattrjacobs is referring to:

    @Test
    public void testFinallyError() {
        Action0 errorAction = new Action0() {

            @Override
            public void call() {
                throw new RuntimeException("boo");
            }
        };

        try {
            Observable.create(finallyDo((Observable.toObservable("foo")), errorAction)).subscribe(aObserver);
            fail();
        } catch (Exception e) {
            // pass
        }
    }

@joshgord
Copy link

joshgord commented Apr 3, 2013

We will address the exception handling in another issue and will close this one out now. Thank you very much @abliss for you contribution!!

@joshgord joshgord closed this as completed Apr 3, 2013
rickbw pushed a commit to rickbw/RxJava that referenced this issue Jan 9, 2014
jihoonson pushed a commit to jihoonson/RxJava that referenced this issue Mar 6, 2020
…ethod which returns a CompletableFuture.
jihoonson pushed a commit to jihoonson/RxJava that referenced this issue Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants