Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename switchDo to switchOnNext? #342

Closed
benjchristensen opened this issue Sep 4, 2013 · 5 comments
Closed

Rename switchDo to switchOnNext? #342

benjchristensen opened this issue Sep 4, 2013 · 5 comments

Comments

@benjchristensen
Copy link
Member

I really don't like the 'switchDo' name and am considering renaming to 'switchOnNext' since that's what it does. Ofcourse this is all because we can't use 'switch' as it is a reserved word.

Agreement? Disagreement?
@benjchristensen benjchristensen mentioned this issue Sep 5, 2013
Merged
@benjchristensen
Copy link
Member Author

Just submitted pull request for this ... does anyone have an opinion? People I've asked agree with changing from switchDo to switchOnNext.

@daveray
Copy link
Contributor

daveray commented Sep 5, 2013

switchOnNext is a better name. Works for me.

@jmhofer
Copy link
Contributor

jmhofer commented Sep 5, 2013

I agree. switchOnNext is a lot better.

@benjchristensen
Copy link
Member Author

Proceeding then, that's enough votes for me.

@michaeldejong
Copy link
Contributor

Yeah, switchOnNext is a lot better! Since the PR is merged, can't we close this?

rickbw pushed a commit to rickbw/RxJava that referenced this issue Jan 9, 2014
@benjchristensen
SwitchDo
4bfd6a4 
- remove instance method
- rename to switchOnNext (leaving behind deprecated switchDo for now)

See ReactiveX#342
billyy pushed a commit to billyy/RxJava that referenced this issue Jan 13, 2014
@benjchristensen
SwitchDo
4149aad 
- remove instance method
- rename to switchOnNext (leaving behind deprecated switchDo for now)

See ReactiveX#342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@daveray @jmhofer @michaeldejong @benjchristensen