-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: Observable contract #3132
Comments
I think it should be part of the |
That sounds good to me, and I suppose a copy of it needs to go in the more generic ReactiveX doco. By it you mean the details of the contract extracted from the pdf? |
I'll see if I can work up a summary page about the Observable contract for the website. Are there important elements of this contract that are not reflected in the 2010 Microsoft design guidelines? For example, should there be any discussion of backpressure (e.g. what an Observable should do if it does not support backpressure and an observer attempts to apply it)? |
Here's a first attempt: http://reactivex.io/documentation/contract.html |
Should this page also perhaps discuss the correct behavior of an Observable if an observer does not implement onNext, onError, and/or onCompleted, or of any of those methods throws an exception? |
Thanks @DavidMGross
Single thread is not required, as long as the emissions happen serially (which basically means not in parallel). You could say
@akarnokd will be good for cleaning up this statement! |
https://github.com/reactive-streams/reactive-streams-jvm/#1-publisher-code covers most of it and includes backpressure. It could be translated into RxJava speak and bulked up a bit (the reactive-streams-jvm specification itself is going to be bulked up with comments when people get round to it). |
Please see ReactiveX/reactivex.github.io#133 for my latest draft of the contract, including a discussion of backpressure. I'd appreciate your comments and corrections. |
Thanks, Dave; that's very useful. On Thu, Aug 6, 2015 at 8:46 PM, Dave Moten [email protected] wrote:
David M. Gross |
I think I've got this pretty well nailed down. Let me know if you have any comments, corrections, or additions. |
The Observable contract is mentioned in many places in ReactiveX documentation, rxjava wiki and in
Subject
javadocs but without links or clarification to what it is and where to find it (I think!).I believe the contract is defined in 'Rx Design Guidelines.pdf' section 4 from Microsoft but at the moment this fact is not easily discoverable in the documentation.
My first idea is to create a page in ReactiveX documentation say called Observable contract which itself references the pdf for the moment and then all links would be to that Observable contract page.
@DavidMGross your thoughts?
The text was updated successfully, but these errors were encountered: