Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operation mergeDelayError(Observable<Observable<T>>) does not delay onError of parent observable #313

Closed
EmteZogaf opened this issue Jul 29, 2013 · 7 comments
Labels
Milestone

Comments

@EmteZogaf
Copy link
Contributor

Shouldn't all onError calls including a possible onError call of the parent observable being delayed till all child observables have successfully finished emitting items or called onError themselves?

To get my desired behaviour I changed the code so now the onError method adds the error to the error queue and calls the onCompleted method which already does the propagation of received errors.

@EmteZogaf EmteZogaf reopened this Jul 29, 2013
@benjchristensen
Copy link
Member

If this is still an issue can you provide a unit test?

@EmteZogaf
Copy link
Contributor Author

I wrote a unit test. An Observable of asynchronous child Observables is calling onError after emitting the child Observables.

I created 2 branches:

@benjchristensen
Copy link
Member

Under what circumstances can the parent emit an error? The use cases you provide seem contrived, as mergeDelayError is a static method and therefore there is not a parent Observable to emit an error.

Observable.mergeDelayError(o1, o2, o3).subscribe()

In that code there are 3 Observable instances being merged, but no parent to emit an error.

@benjchristensen
Copy link
Member

Reviewing this again ... the signature where this could be an issue is:

public final static <T> Observable<T> mergeDelayError(Observable<? extends Observable<? extends T>> source)

@benjchristensen benjchristensen added this to the 1.0 milestone Jul 24, 2014
@benjchristensen
Copy link
Member

Marking to be included in 1.0 work.

@EmteZogaf
Copy link
Contributor Author

I'm sorry for this late reply. I haven't looked into this issue for a while as our project using RxJava is running without any problems. But I will try to update to the new version next month and use base RxJava only without any customizations we made to it back then. If this is still an issue I'll report here.

@benjchristensen
Copy link
Member

Marking as 1.x as this doesn't require a signature change so can be fixed without holding up 1.0

@benjchristensen benjchristensen modified the milestones: 1.x, 1.0 Sep 23, 2014
@benjchristensen benjchristensen modified the milestones: 1.0.x, 1.x, 1.0 Oct 10, 2014
benjchristensen pushed a commit to benjchristensen/RxJava that referenced this issue Nov 6, 2014
benjchristensen added a commit to benjchristensen/RxJava that referenced this issue Nov 6, 2014
benjchristensen pushed a commit to benjchristensen/RxJava that referenced this issue Nov 6, 2014
benjchristensen added a commit to benjchristensen/RxJava that referenced this issue Nov 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants