-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Operation mergeDelayError(Observable<Observable<T>>) does not delay onError of parent observable #313
Comments
If this is still an issue can you provide a unit test? |
I wrote a unit test. An Observable of asynchronous child Observables is calling onError after emitting the child Observables. I created 2 branches:
|
Under what circumstances can the parent emit an error? The use cases you provide seem contrived, as Observable.mergeDelayError(o1, o2, o3).subscribe() In that code there are 3 |
Reviewing this again ... the signature where this could be an issue is: public final static <T> Observable<T> mergeDelayError(Observable<? extends Observable<? extends T>> source) |
Marking to be included in 1.0 work. |
I'm sorry for this late reply. I haven't looked into this issue for a while as our project using RxJava is running without any problems. But I will try to update to the new version next month and use base RxJava only without any customizations we made to it back then. If this is still an issue I'll report here. |
Marking as 1.x as this doesn't require a signature change so can be fixed without holding up 1.0 |
… 313-mergeDelayError Unit test for ReactiveX#313
… 313-mergeDelayError Unit test for ReactiveX#313
Shouldn't all onError calls including a possible onError call of the parent observable being delayed till all child observables have successfully finished emitting items or called onError themselves?
To get my desired behaviour I changed the code so now the onError method adds the error to the error queue and calls the onCompleted method which already does the propagation of received errors.
The text was updated successfully, but these errors were encountered: