-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name for DefaultSubject #242
Comments
@johngmyers @mairbek and @jmhofer if you have opinions on this I'd appreciate them since you are all involved in and touching code in this area. |
I believe the |
I'll like the |
Then I'll rename this to |
@johngmyers Thanks for clarifying this:
If that's the case the name |
When binding directly to a registry we create our initial meters without any additional tags that might be applied by meter filters. This causes the meter to be duplicated, once with no tags and again with the common tags. Resolve: ReactiveX#242
In .Net there is
ISubject
andSubject
.Right now we have
Subject
as the abstract (instead of interface) since we don't prefix with I but that means our concrete class needs a different name.What should it be called?
It's
DefaultSubject
right now and I don't like that.@johngmyers had the name
PublishSubject
which I think I like better but want to make sure it truly represents what it does and won't interfere with anything else we need to use in the future. My hesitance on it and why I stuck with DefaultSubject right now is how does this relate to thepublish
operator we need to add?I'll need to read up more on the overall .Net API, Subjects and Publish but if anyone else can weigh in I'd appreciate it.
The text was updated successfully, but these errors were encountered: