Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name for DefaultSubject #242

Closed
benjchristensen opened this issue Apr 18, 2013 · 5 comments
Closed

Name for DefaultSubject #242

benjchristensen opened this issue Apr 18, 2013 · 5 comments

Comments

@benjchristensen
Copy link
Member

In .Net there is ISubject and Subject.

Right now we have Subject as the abstract (instead of interface) since we don't prefix with I but that means our concrete class needs a different name.

What should it be called?

It's DefaultSubject right now and I don't like that.

@johngmyers had the name PublishSubject which I think I like better but want to make sure it truly represents what it does and won't interfere with anything else we need to use in the future. My hesitance on it and why I stuck with DefaultSubject right now is how does this relate to the publish operator we need to add?

I'll need to read up more on the overall .Net API, Subjects and Publish but if anyone else can weigh in I'd appreciate it.

@benjchristensen
Copy link
Member Author

@johngmyers @mairbek and @jmhofer if you have opinions on this I'd appreciate them since you are all involved in and touching code in this area.

@johngmyers
Copy link
Contributor

I believe the publish operator will wrap a ConnectableObservable around a PublishSubject.

@mairbek
Copy link
Contributor

mairbek commented Apr 19, 2013

I'll like the PublishSubject name instead of DefaultSubject.

@benjchristensen
Copy link
Member Author

Then I'll rename this to PublishSubject before I release 0.8.0 (which I want to do today to get improved Schedulers into people's hands).

@benjchristensen
Copy link
Member Author

@johngmyers Thanks for clarifying this:

I believe the publish operator will wrap a ConnectableObservable around a PublishSubject.

If that's the case the name PublishSubject makes sense and shouldn't collide elsewhere.

rickbw pushed a commit to rickbw/RxJava that referenced this issue Jan 9, 2014
jihoonson pushed a commit to jihoonson/RxJava that referenced this issue Mar 6, 2020
When binding directly to a registry we create our initial meters
without any additional tags that might be applied by meter filters.
This causes the meter to be duplicated, once with no tags and again with
the common tags.

Resolve: ReactiveX#242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants