Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw if no onError handler specified #198

Closed
benjchristensen opened this issue Mar 19, 2013 · 3 comments
Closed

Throw if no onError handler specified #198

benjchristensen opened this issue Mar 19, 2013 · 3 comments
Milestone
0.7

Comments

@benjchristensen
Copy link
Member

If an onError handler is not provided we should throw an exception if an error occurs even though it will likely show up on some other thread.
@benjchristensen benjchristensen mentioned this issue Mar 31, 2013
Closed
@mttkay
Copy link
Contributor

mttkay commented Apr 23, 2013

To back this up, the relevant section from the Rx Design Guildelines says:

"E.g. when calling the Subscribe method that only has an onNext argument, the OnError behavior will be to rethrow the exception on the thread that the message comes out from the observable sequence. The OnCompleted behavior in this case is to do nothing."

(v1.0, section 5.2, p11)

@Treora Treora mentioned this issue May 26, 2013
Closed
@benjchristensen benjchristensen mentioned this issue Jun 3, 2013
Merged
@mttkay
Copy link
Contributor

mttkay commented Jul 7, 2013

Is this closed with the above PR?

@mttkay
Copy link
Contributor

mttkay commented Jul 20, 2013

I noticed this went into 0.9.1 👍

rickbw pushed a commit to rickbw/RxJava that referenced this issue Jan 9, 2014
@benjchristensen
Throw if no onError handler specified
5b1c115 
ReactiveX#198

As per Rx Design Guidelines 5.2:

 "when calling the Subscribe method that only has an onNext argument, the OnError behavior will be
 to rethrow the exception on the thread that the message comes out from the observable sequence.
 The OnCompleted behavior in this case is to do nothing."

A new OnErrorNotImplementedException was created so it is explicit as to where the exception is coming from and why.
@kotucz kotucz mentioned this issue Feb 24, 2016
Closed
jihoonson pushed a commit to jihoonson/RxJava that referenced this issue Mar 6, 2020
@danielimre @RobWin
Refactor RateLimiter RxJava operators. (ReactiveX#198)
0b58985 
Add Maybe and Completable RateLimiter operator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7
Development

No branches or pull requests
2 participants
@mttkay @benjchristensen