RxScala Schedulers

[headinthebox]

I think it is a mistake to use Unit => Unit instead of () => Unit. Any takers, or I'll fix it later this week.

trait Worker extends Subscription {
  private [scala] val asJavaWorker: rx.Scheduler.Worker

  /**
   * Schedules a cancelable action to be executed in delayTime.
   */
  def schedule(action: Unit => Unit, delayTime: Duration): Subscription =
    this.asJavaWorker.schedule(
      new Action0 {
        override def call(): Unit = action()
      },
      delayTime.length,
      delayTime.unit)

  /**
   * Schedules a cancelable action to be executed immediately.
   */
  def schedule(action: Unit => Unit): Subscription = this.asJavaWorker.schedule(
    new Action0 {
      override def call(): Unit = action()
    }
  )

[zsxwing]

The original implementation uses (action: => Unit). Do you think which one is better? I prefer (action: => Unit).

[headinthebox]

=>Unit would be even better.

[headinthebox]

One caveat, to do recursive scheduling we might want to use the same method as in Java; which does not seem to work with =>Unit.

def random(seed: Int): Observable[Double] = {
    Observable(subscriber => {
      val r: Random = new Random(seed)
      val inner = rx.lang.scala.schedulers.NewThreadScheduler().createWorker
      subscriber.add(inner)

      inner.schedule(new Function[Unit, Unit]{
        override def apply(unit: Unit): Unit = {
          val n = r.nextDouble()
          subscriber.onNext(n)
          inner.schedule(apply)
        }
      })
    })
  }

[zsxwing]

OK. I'll take it and add some examples to test the signature.

[headinthebox]

Cool.

[samuelgruetter]

this is nice :)

[benjchristensen]

@zsxwing Is this done after merging that PR?

[zsxwing]

Yes, already fixed.