Merge pull request #1521 from benjchristensen/issue-1450

Fix toIterator Exception Handling
ReactiveX · Jul 25, 2014 · eccbe4c · eccbe4c
2 parents 41425ef + 11374c2
commit eccbe4c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/rxjava-core/src/main/java/rx/internal/operators/BlockingOperatorToIterator.java b/rxjava-core/src/main/java/rx/internal/operators/BlockingOperatorToIterator.java
@@ -55,7 +55,7 @@ public void onCompleted() {
 
             @Override
             public void onError(Throwable e) {
-                // ignore
+                notifications.offer(Notification.<T>createOnError(e));
             }
 
             @Override

diff --git a/rxjava-core/src/test/java/rx/internal/operators/BlockingOperatorToIteratorTest.java b/rxjava-core/src/test/java/rx/internal/operators/BlockingOperatorToIteratorTest.java
@@ -67,4 +67,18 @@ public void call(Subscriber<? super String> observer) {
         assertEquals(true, it.hasNext());
         it.next();
     }
+
+    @Test(expected = TestException.class)
+    public void testExceptionThrownFromOnSubscribe() {
+        Iterable<String> strings = Observable.create(new Observable.OnSubscribe<String>() {
+            @Override
+            public void call(Subscriber<? super String> subscriber) {
+                throw new TestException("intentional");
+            }
+        }).toBlocking().toIterable();
+        for (String string : strings) {
+            // never reaches here
+            System.out.println(string);
+        }
+    }
 }