-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #2948 from ReactiveX/TestSubscriberPlus
More assertions for TestSubscriber
- Loading branch information
Showing
1 changed file
with
180 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I merged this but now realize that this is a different naming convention than the
assertReceivedOnNext
that it is a cover method for. I understand that it's a shorter name, but now we have two names for the same thing and that hinders discoverability and understanding. The obvious question will then always be "what's the difference?".I suggest we keep the existing naming as we can't remove
assertReceivedOnNext
.