considers async option in HandlerScheduler.scheduleDirect #442
Conversation
|
This needs tests. Are you able to write them? If not, I can get to it sometime in the next week or two. |
|
oh sorry, i forget writing test... But, I think already HandlerSchedulerTest is considering the async option test by Parameterized test. Are there other missing tests? Please tell me if any missing test. |
|
Coverage is definitely missing. Either the test should have been failing before without this change or we aren't covering this codepath. Since the test is passing, we have missing coverage on this codepath. |
|
The parameterized test just expects no regressions. There weren't any cases added that would have failed the the non-async implementation, as I'm not really sure how to coerce vsync behavior out of robolectric :X |
|
You don't need to. We just need to assert the flag is set through all scheduler code paths. There's already a test which asserts that flag is not set on pre-16 which I added. |
|
Ah didn't know that was added 😬 |
|
We just need to add ones which check each scheduler method and assert the flag is set to true on the messages. We should have been doing that anyway... |
|
thx 😄
i write a test! |
|
@JakeWharton @hzsweers i added test for async option 😃 |
|
Thanks!
…On Fri, Feb 15, 2019 at 7:10 PM Jake Wharton ***@***.***> wrote:
Merged #442 <#442> into 2.x.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#442 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABTEvkIfSusnBGmMZWDeX6l6vaE3hdElks5vNwYsgaJpZM4WaNVE>
.
|
close #441