Xcode 10 support #51
Merged
Xcode 10 support #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For compatibility with testing frameworks
asmallteapot
approved these changes
Jun 7, 2018
| @@ -418,7 +418,7 @@ extension SignalProtocol where Value: OptionalProtocol, Value.Wrapped: AnyObject | |||
| } | |||
|
|
|||
| extension Action { | |||
| fileprivate var isEnabled: RACSignal<NSNumber> { | |||
| fileprivate var _isEnabled: RACSignal<NSNumber> { | |||
There was a problem hiding this comment.
Or possibly racIsEnabled or rac_isEnabled? 🤔
There was a problem hiding this comment.
Yeah, I'm happy with isEnabledSignal 👍 thanks!
Swift 4.2 doesn't seem to be able to handle properties overloaded on return type, which results in this failing to type check. Using an alternative name for the private property works around the problem.
sharplet
commented
Jun 8, 2018
| @@ -1113,6 +1113,7 @@ | |||
| "$(PROJECT_DIR)/build/Debug", | |||
| ); | |||
| INFOPLIST_FILE = ReactiveObjCBridgeTests/Info.plist; | |||
| MACOSX_DEPLOYMENT_TARGET = 10.10; | |||
There was a problem hiding this comment.
FYI: I only changed these deployment targets in test targets.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main fix was a case where we were overloading a computed property based on
return type, which no longer works in Swift 4.2