fix exhaustive switch error in Xcode 9 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdiep
approved these changes
Jul 15, 2017
|
This is great! Thanks for opening a PR! |
|
@mdiep Any way we can make a 1.0.3 release with just this fix? |
|
We can definitely do that. Would you mind opening a PR that gets everything set for a 1.1 release?
Once that's done and merged, then I can actually tag a release. |
|
Sure! Branching it off of d527356 (the 1.0.2 commit)? Because we have other stuff on master which I suppose we don't want in. |
|
I think the other things on |
The requirement in podspec should also be updated. |
|
All right, I'll do it tonight. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accounting for the new case in
DispatchTimeIntervalhas been done in other ReactiveCocoa projects, but not this one.