Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only overwrite ANDROID_AVD_HOME if not set #405

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tmpsantos
Copy link

The path might point to a different path than what android-emulator-runner expects, like when XDG_CONFIG_HOME is set.

The path might point to a different path than what
android-emulator-runner expects, like when XDG_CONFIG_HOME
is set.
@tmpsantos
Copy link
Author

What I'm seeing here is because XDG_CONFIG_HOME is set, it is being used as base path for where the emulator is being created and it breaks when the script tries to append the hardware configuration because it is hardcoded to the home directory.

@mikehardy
Copy link

@ychescale9 this (XDG_CONFIG_HOME) is probably the root cause of what I saw with the weird pathing issues for AVD home - since XDG_CONFIG_HOME is $HOME/.config and that was the root path the avdmanager was installing in to on Ubuntu 24

In #410 I specify even more variables, which ... works, but this solution might be more respectful of the system, and setting the other AVD related env vars (ANDROID_EMULATOR_HOME, ANDROID_USER_HOME) based on the existing ANDROID_AVD_HOME might be a better idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants