Add support for pinning emulator build #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ychescale9
force-pushed
the
yc/support-emulator-build
branch
from
efe06b8 to
7b4b27a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11
Currently the
sdkmanagerinstalls the latest emulator binary from the stable channel, which means when a new release of the emulator has issues, projects using this action will start breaking.Pinning the emulator binary to a specific version requires a list of
[emulator binary version : download url mappings]which isn't currently available (feature request).Therefore as a temporary solution we allow users to provide the emulator build number as an input and we'll use this to derive the download url -
emulator-darwin-<build-number>and download the emulator binary directly instead of using thesdkmanager.This is a temporary solution for users who need to pin the emulator build or when stable release breaks again in the future. In a future we'll add a proper
emulator-versioninput once the mappings are available.