Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

Fixed overloads to avoid catch-all function taking over all overloads. #1030

Merged

Conversation

DanielRosenwasser
Copy link
Contributor

Found from this microsoft/TypeScript#5453 (comment)

Basically users would never get any sort of useful inference because the top overload would always match during resolution. The problem is that any function type is assignable to Function (and Function itself does't imply 0 parameters).

@ghost
Copy link

ghost commented Nov 13, 2015

Hi @DanielRosenwasser, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Daniel Rosenwasser). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla2.msopentech.com.

TTYL, MSOTBOT;

@ghost ghost added the cla-not-required label Nov 13, 2015
mattpodwysocki added a commit that referenced this pull request Nov 13, 2015
Fixed overloads to avoid catch-all function taking over all overloads.
@mattpodwysocki mattpodwysocki merged commit 6fb0431 into Reactive-Extensions:master Nov 13, 2015
@DanielRosenwasser DanielRosenwasser deleted the fixOverloads branch November 13, 2015 23:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants