Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use SourceLink.Create.CommandLine #393

Merged
merged 2 commits into from
Apr 21, 2017
Merged

use SourceLink.Create.CommandLine #393

merged 2 commits into from
Apr 21, 2017

Conversation

ctaggart
Copy link
Contributor

@ctaggart ctaggart commented Apr 21, 2017 •
edited
Loading

This enables SourceLink again, but uses SourceLink.Create.CommandLine which is new to 2.1. It simply uses the git command line and not dotnet.

image

I downloaded the nupkg and validated that it works:
https://ci.appveyor.com/project/ctaggart/rx-net/build/4.0.0-develop-test.319.build.18

dotnet sourcelink test C:\Users\CameronTaggart\Downloads\System.Reactive.4.0.0-develop-test.319.nupkg
sourcelink test passed: lib/netstandard1.3/System.Reactive.dll
sourcelink test passed: lib/net45/System.Reactive.dll
sourcelink test passed: lib/net46/System.Reactive.dll
sourcelink test passed: lib/uap10.0/System.Reactive.dll

This was referenced Apr 21, 2017
Closed
Merged
@clairernovotny clairernovotny merged commit 46dda16 into dotnet:develop Apr 21, 2017
@clairernovotny clairernovotny modified the milestone: 4.0 May 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[area] Ix [area] Rx
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ctaggart @clairernovotny @dnfclas @shiftkey