-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update ios and android builds #137
fix: update ios and android builds #137
Conversation
Avtrkrb
commented
Feb 14, 2024
•
edited
Loading
edited
- Upgrades
- viroar
- viroreact
- virocore
- sharedCode
- viro_renderer
- ARcore
- Upgrade arcore 1.26.0 -> 1.41.0
- Migrate
- com.google.android.exoplayer2 -> androidx.media3.exoplayer
- Bug fixes
- com.google.android.exoplayer2 -> androidx.media3.exoplayer
…Still WIP to fix some build issues.
…ded to arcore 1.41.0. Tested with custom app.
This pr needs to be merged before the this pr on the viro repo. |
- Adds build script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! @Avtrkrb can you confirm that you're able to run ./prepare_release.sh
here?
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | Google API Key | e5a9f99 | android/releasetest/src/main/AndroidManifest.xml | View secret | |
- | Google API Key | e5a9f99 | android/renderertest/src/main/AndroidManifest.xml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
63829a2
to
b8c28f0
Compare