Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add react_app prefix into the available env variables #1062

Closed
wants to merge 3 commits into from

Conversation

danielbarion
Copy link
Member

close #1060

@danielbarion
Copy link
Member Author

@gabrieljablonski please go ahead to merge it and do a new release when you have time, thanks!

@gabrieljablonski
Copy link
Member

@danielbarion I was actually still unable to make this work on a fresh CRA project. Looking into it.

@gabrieljablonski
Copy link
Member

@danielbarion Apparently using anything other than process.env.NODE_ENV from inside node_modules does not seem that trivial. Tried a few things and still couldn't get it to work.

Please also try looking into this whenever you have the time.

@danielbarion
Copy link
Member Author

@gabrieljablonski
image
image

The issue is that process is undefined on the browser, even with CRA being able to get the envs

I'll try to solve it

@danielbarion
Copy link
Member Author

When I remove the validation:
image

image

@gabrieljablonski
Copy link
Member

Dropped env variables in favor of #1052

@danielbarion danielbarion deleted the fix/react-scripts-env-prefix branch November 22, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Unable to disable style injection
2 participants