Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Announcements #257

Draft
wants to merge 72 commits into
base: dev
Choose a base branch
from
Draft

Conversation

madkarmaa
Copy link
Member

@madkarmaa madkarmaa commented Sep 8, 2024

What's this?

This is a new, more updated continuation of #195

TODO:

  • Add styles
  • Add login admin functionality
  • Add 3 dots on cards for admins to edit or delete
  • Add edit, add, delete announcement admin functionality
  • Remove boilerplate response code
  • Footer shifts up when content is little
  • Attachments not shown on announcement page
  • Only first attachment shown on announcements page
  • New API changes need to be applied (such as paging or tags)
  • Some design suggestions should be applied:
    image

@madkarmaa madkarmaa self-assigned this Sep 8, 2024
@oSumAtrIX oSumAtrIX mentioned this pull request Sep 8, 2024
5 tasks
@Ushie Ushie changed the title feat: announcements feat: Announcements Sep 8, 2024
@Ushie
Copy link
Member

Ushie commented Nov 6, 2024

Only first attachment shown on announcements page

Well, that's intentional, as it's a thumbnail not a gallery

@oSumAtrIX
Copy link
Member

The first attachment is not intended to be a thumbnail. There is no concept of thumbnails in announcements, so you arbitrarily chose the first as one. Can't say if this is really a good idea

@oSumAtrIX oSumAtrIX closed this Nov 6, 2024
@oSumAtrIX oSumAtrIX reopened this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants