-
-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(YouTube - Settings): Add option to use new Cairo settings menus #4305
feat(YouTube - Settings): Add option to use new Cairo settings menus #4305
Conversation
Regarding the icons, it looks like YT only uses icons for the top level preferences and not for individual preferences, so there's no need to add icons to them in the ReVanced preferences |
… and 'Miscellaneous' menu titles.
The ReVanced icon looks slightly too bold compared to the other YouTube icons. Not a requirement, but it would be nice to have if a 'slim' version of the logo existed. |
Maybe try reducing the |
I tried but it doesn't change anything. Stroke width is the edge of the fill, and since the edge of the fill is the same as the fill it makes no difference, I also tried using EnDesign to modify the original file, but couldn't find any simple way to 'slim' the 'V' shape without manually mucking about (art design is not my thing). |
…ctions work the same
bdc4380
to
35ef6f9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
9c28a2b
to
ec014dd
Compare
@LisoUseInAIKyrios Consider to move the about button inside revanced settings outside, in revanced section of general settings. I think it makes more sense. |
I think the settings button is convenient when it's the first item. Having some items in the YT root menu while all the rest are in the sub menu might feel kind of weird. |
Preference Categories can now be added, but I can only think of 3 or 4 places where they might help with organizing (and then the settings might feel a little weird with random groups in some places but not others). So far submenus and alphabetical sorting has worked ok so maybe groups are not needed. |
The settings patch of ReVanced should inject one preference in apps and patches are then free to add subpreferences. About belongs inside the ReVanced preference |
An outline version can be created and tracked here https://github.com/ReVanced/revanced-branding |
@oSumAtrIX can you upload that SVG/xml here or to the branding repo? |
The image above is an svg, you should be able to open it and right click and save. The reason I don't want to put it in the branding repo is because each situation would ask for a different stroke width. The fill version is already on the branding repo out of which a stroke version can be made depending on the situations needs, no guidelines in that regard |
I guess the shape can be converted to a V and the diamond can stay a triangle. Would need to figure out how to achieve that conversion from the current paths |
Could try remove some points of the V path to leave only the top of the V outline. |
The V stroke should be perfectly inside the V shape, but I'm not sure how one would calculate that. Probably possible easily |
Try converting to drawable xml and see how it looks in app. The stroke width may need to be more slender to better match the stock icons. |
Edit: Removed unnecessary attributes:
|
Not ideal, but I think it's an improvement over the previous. Can the bottom of the V be slightly flatter? It looks the same as the other logos except the bottom of the V looks a little pointy. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
5fd9ceb
to
e11f6d6
Compare
So what's left is knowing if/how you calculated the stroke from the shape of the V. For reference https://graphicdesign.stackexchange.com/questions/33792/convert-shape-to-line-with-a-stroke-in-illustrator |
patches/src/main/kotlin/app/revanced/patches/youtube/misc/settings/SettingsPatch.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just the logo needs to be figured out.
Here is the logo with correct strokes |
# [5.9.0-dev.3](v5.9.0-dev.2...v5.9.0-dev.3) (2025-01-19) ### Features * **YouTube - Settings:** Add option to use new Cairo settings menus ([#4305](#4305)) ([7b8a2a2](7b8a2a2))
It looks good when it's a large logo, but when it's scaled down to 16x16dip the bottom looks too pointy and visually becomes different from the flat bottom V shape of the regular logo. Maybe the bottom needs to be clipped flat and the V intersection curve moved up a little. SVG is not my thing so I'm unfamiliar with how to try that. |
# [5.9.0](v5.8.1...v5.9.0) (2025-01-20) ### Bug Fixes * **YouTube - Spoof video streams:** Resolve playback issues after changing from cellular to wifi ([#4277](#4277)) ([e93e1c8](e93e1c8)) * **YouTube - Spoof video streams:** Update client user-agent ([#4304](#4304)) ([7917871](7917871)) ### Features * **YouTube - Hide feed components:** Handle new type of surveys ([#4295](#4295)) ([c770e03](c770e03)) * **YouTube - Playback speed:** Add option to change 2x tap and hold speed ([#4307](#4307)) ([02fb26e](02fb26e)) * **YouTube - Settings:** Add option to use new Cairo settings menus ([#4305](#4305)) ([7b8a2a2](7b8a2a2))
Adds a setting option to enable/disable the new YouTube Cairo settings menus.
If YouTube Cairo style settings are enabled, then some other parts of the app also change such as the watch history seekbar progress bar that uses a two color cairo theme.