-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(YouTube Music - AMOLED black theme): Add AMOLED black theme
patch
#4258
base: dev
Are you sure you want to change the base?
feat(YouTube Music - AMOLED black theme): Add AMOLED black theme
patch
#4258
Conversation
extensions/music/src/main/java/app/revanced/extension/music/ThemeHelper.java
Outdated
Show resolved
Hide resolved
.../src/main/kotlin/app/revanced/patches/music/layout/amoledblacktheme/AmoledBlackThemePatch.kt
Outdated
Show resolved
Hide resolved
Is it any better now or just worse? |
You're getting there; however, there's missing/incorrect abstraction, which isn't as easy to pull off as copying or moving files. I think it's better leaving this to us. |
@oSumAtrIX , do you think navigation bar theme is defined in the xml files so that this can work ? document("res/values/themes.xml").use { document -> val resourcesNode = document.getElementsByTagName("resources").item(0) as Element for (i in 0 until resourcesNode.childNodes.length) { val node = resourcesNode.childNodes.item(i) as? Element ?: continue if (node.getAttribute("name") == "navigation_bar_color") { node.textContent = amoledBlackColor |
The reason I asked is mentioned in this #609 (comment). As currently, ReVanced YouTube Music settings page implementation is in works, only features that can be achieved while patching can be added, which is the theme patch. Theming should all fall under one patch and the nav bar theme being separate felt off to me and I would like it to come under this patch as well but I don't know how to achieve that. Will you be able to look into that as well or should I do something about that? |
I don't know what you're referring to with the settings, but theming for YT doesn't rely on the settings patch. |
I don't think you read my comment completely. |
Please refer patches/src/main/kotlin/app/revanced/patches/music/layout/theme/DarkThemePatch.kt as he has made some changes and is now much more similar to our YouTube |
Closes #609, #614 (partially), #1391(partially), and #1491. (I know, all of them are my issues, crazy right.)
I have no idea what I've done here. But, since there's no one else to do this (at least for now), I shall be the Guinea pig. Open to changes (and many of that shall come).
Credits: @inotia00