Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add string format indexes, to allow more flexible translations #2956

Conversation

LisoUseInAIKyrios
Copy link
Contributor

Adds format indexes, so translations can rearrange the formatted words/numbers if needed.

Copy link
Member

@oSumAtrIX oSumAtrIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If no integration changes are necessary, this lgtm. Currently, String.format is used in integrations for parametrized strings.

@LisoUseInAIKyrios LisoUseInAIKyrios merged commit 16ce280 into ReVanced:dev Mar 30, 2024
2 checks passed
@LisoUseInAIKyrios LisoUseInAIKyrios deleted the refactor_crowdin_tags_comments branch March 30, 2024 22:12
@LisoUseInAIKyrios
Copy link
Contributor Author

LisoUseInAIKyrios commented Mar 31, 2024

How often does the crowdin sync task run?

If I am reading the yml cron statement right, it syncs once a month?

Can we manually run the task if many relevant changes were made (like now?)

@Ushie
Copy link
Member

Ushie commented Mar 31, 2024

Yes, you can manually dispatch it in the actions tab -> "sync crowdin" on the sidebar -> dropdown menu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants