Skip to content

Commit

Permalink
chore: Fix Crowdin push, part trois
Browse files Browse the repository at this point in the history
  • Loading branch information
@LisoUseInAIKyrios
LisoUseInAIKyrios committed Jun 27, 2024
1 parent 4dadafe commit e2a9b1e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/pull_strings.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ jobs:
uses: actions/checkout@v4
with:
fetch-depth: 0
ref: dev

- name: Pull strings
uses: crowdin/github-action@v1
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/push_strings.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ jobs:
uses: actions/checkout@v4
with:
fetch-depth: 0
ref: dev

This comment has been minimized.

Sign in to view

Copy link
@oSumAtrIX

oSumAtrIX Jun 27, 2024 •
edited
Loading

Member

May be not necessary since the dispatch can be set to dev branch & the push path should only trigger on the selected dev branch. The syntax above needs to be fixed:

on:
    workflow_dispatch:
    push:
        paths:
            - /src/main/resources/addresources/values/strings.xml
	    branches:
	    	- dev

(Also squash & force push dev once done with testing workflows :))

This comment has been minimized.

Sign in to view

Copy link
@LisoUseInAIKyrios

LisoUseInAIKyrios Jun 27, 2024

Author Contributor

Something is still missing here. It's not running the action when the string file is modified.

This comment has been minimized.

Sign in to view

Copy link
@LisoUseInAIKyrios

LisoUseInAIKyrios Jun 27, 2024

Author Contributor

Oh wait the indentation isn't right. trying again.

This comment has been minimized.

Sign in to view

Copy link
@LisoUseInAIKyrios

LisoUseInAIKyrios Jun 27, 2024

Author Contributor

No the indentation is right. Not sure what to change here.

- name: Push strings
uses: crowdin/github-action@v1
Expand Down

0 comments on commit e2a9b1e

Please sign in to comment.