fix(youtube/custom-branding): use highest resolution adaptive icons

[LisoUseInAIKyrios]

I fixed the tiny app icon, and also increased the size of the adaptive images to the full resolution (108px, 162px, 216px, 324px, 432px)

I did this using the original high resolution image here on GitHub. By coincidence, it was the ideal size.

I also updated the old legacy ic_launcher.png and ic_launcher_round.png, although I don't think those are ever used because Android 8 uses the adaptive icons (and YouTube requires Android 8 or higher).

Before:

After:

[oSumAtrIX]

It seems like the size is a bit off, here are the resources for the ReVanced logo with source and SVG files as reference: revanced-brand-identity.zip.

[LisoUseInAIKyrios]

It seems like the size is a bit off, here are the resources for the ReVanced logo with source and SVG files as reference: revanced-brand-identity.zip.

This first iteration I made the icon the same size as ReVanced Manager:

I could revert the second change, and use this first change only.

Of note, ReVanced Manager also is using the wrong icon sizes (Manager is using 192px for xxxhdpi, when it should be 432px).

[oSumAtrIX]

While it might look personally better, we should remain consistent with branding. There will soon be a logo poll that will allow for minor adjustments like your personal opinion before finalization, but in favour of brand consistency, it is currently required for the logo to match the exact size of the original logo.

[LisoUseInAIKyrios]

Here it is constructed from revanced-logo-no-background.svg

[oSumAtrIX]

I believe the right one is the patched YouTube app. If so, this PR is ready for merge

[LisoUseInAIKyrios]

I believe the right one is the patched YouTube app. If so, this PR is ready for merge

Yes that is correct. Merge away.

Should I do another PR to update the adaptive icons for the manager? It's has the same low resolution adaptive icons, which is why it looks a little blurry in these screenshots.

[oSumAtrIX]

That sounds reasonable to me. Currently there is also the repo for the compose ReVanced Manager app, which might be relevant as well.

[oSumAtrIX]

Thanks!

[kazimmt]

@oSumAtrIX the edge of the changed logo is not correct :)

[oSumAtrIX]

Yep, I noticed already, will have to be fixed before merge to main

[LisoUseInAIKyrios]

The image is stacked together with the background PNG, so it should never be seen individually. I will recreate using a variable alpha layer.

Is there a reason for both a foreground and background image? Why not use just 1 image?

[oSumAtrIX]

Iirc thats an Android specification.

[kazimmt]

The image is stacked together with the background PNG, so it should never be seen individually. I will recreate using a variable alpha layer.

Is there a reason for both a foreground and background image? Why not use just 1 image?

I think everything was fine on last version
Except adaptiveproduct_youtube_foreground_color_108 in mipmap-xxxhdpi folder

Mistakenly it was a little small compare to others

[LisoUseInAIKyrios]

I recreated them all using revanced-logo-shape.svg

edit: new PR: ReVanced/revanced-patches#1580

[kazimmt]

I recreated them all using revanced-logo-shape.svg

new PR: #1576

Ok, whatever
It needs fix again
I'll wait till logo poll

[LisoUseInAIKyrios]

I think everything was fine on last version Except adaptiveproduct_youtube_foreground_color_108 in mipmap-xxxhdpi folder

Mistakenly it was a little small compare to others

The screenshot I posted is my device that uses xxxhdpi. Maybe the GitHub visual diff makes them look a different ratio to each other, but that's the right size to match the Manager.

[oSumAtrIX]

The ReVanced Manager app is also using wrong icon sizes, you should not match against it

[kazimmt]

The ReVanced Manager app is also using wrong icon sizes, you should not match against it

The main icon (from branding zip) is not correctly aligned tho. (my 600% zoom -_- )

[LisoUseInAIKyrios]

How much larger?

Here is:

First is 5% larger. Second is 10% larger.

[oSumAtrIX]

@kazimmt it is aligned, you can check the source file or inspect the svg path to confirm.

[oSumAtrIX]

@LisoUseInAIKyrios Why is a scaling required at all? Can't the svg directly be used as the logo?

[kazimmt]

@kazimmt it is aligned, you can check the source file or inspect the svg path to confirm.

Check Discord. I've already post the ss about alignment error.

[LisoUseInAIKyrios]

So Android uses the center 2/3rd of the foreground image (72px / 108px)

the SVG uses 1/10% padding. It needs to be 1/3rd.

Creating the foreground SVG using (2/3)/(1728/1920) * 432 = 320px
then expanding the canvas of the 320px foreground image to 432px and using this as the foreground icon, Android shows this as:

Original SVG output without the blank padding:

Android shows the logo using 43.83% of the circle vertical space.
The original SVG shows the logo using 43.75% of the circle vertical space.

So now it's a match.

[LisoUseInAIKyrios]

I changed the adaptive foreground to match the SVG and it's checked in on ReVanced/revanced-patches#1580

Ideally, any future ReVanced SVG logo changes would use the same padding ratios (1/6th padding on each side)

[oSumAtrIX]

@LisoUseInAIKyrios I see the motivation behind using an 1/6th padding ratio, though if we would use that, the full logo would look off. The original padding of the shape in the logo project file was used in the shape svg file in order to correctly match in size with the full logo svg. Does that sound reasonable?

[LisoUseInAIKyrios]

Then there's no strong reason to change the padding of the original SVG's. When exporting the icons Its easy to adjust the padding before exporting the SVG to PNG's.

[kazimmt]

@LisoUseInAIKyrios why not we include the gradient background also?
It's part of logo background. Right?

[LisoUseInAIKyrios]

@LisoUseInAIKyrios why not we include the gradient background also? It's part of logo background. Right?

You mean like this?

Is this the correct behavior? It's forcing the circle, even though the device is cutting it into a different shape.

[oSumAtrIX]

I believe what he means is something like on the README file:

[kazimmt]

Maybe padding a little more
So the black circle is not in the edge

Btw it's my personal preference
Idk what osuMatrix thought

[kazimmt]

I believe what he means is something like on the README file:

Exactly

[kazimmt]

I'm worried about this shape

Who use this 😅

[kazimmt]

I believe what he means is something like on the README file:

Btw README.md logo also needs fix (as per branding guide)

[LisoUseInAIKyrios]

I'm worried about this shape

It's the 'cylinder' shape from stock Android 12 launcher. Yeah it's an oddball.

[oSumAtrIX]

Please PR or open an issue regarding this. @kazimmt

[oSumAtrIX]

t'll look almost the same

I think whats necessary is a certain padding:

It should be noted that the correct padding would have to be added for Android in order to allow for the gradient border to look like this:

Otherwise it would look like this:

[kazimmt]

@oSumAtrIX i think icon pack also matters
I test on miui with different icon pack
& here is the result

[oSumAtrIX]

In that case, the gradient should not be added.

[kazimmt]

In that case, the gradient should not be added.

Maybe there is another way
Let me try it

[LisoUseInAIKyrios]

And the results:

[LisoUseInAIKyrios]

In that case, the gradient should not be added.

Maybe there is another way Let me try it

What exactly was in that icon test pack?

[kazimmt]

And the results:

Looks Good

[kazimmt]

Maybe there is another way Let me try it

What exactly was in that icon test pack?

It's ReVanced Manager --
I just changed the name & package for testing --

[LisoUseInAIKyrios]

Looks Good

I agree

[kazimmt]

Needs test on Memeui (MIUI) & Other OS too

[oSumAtrIX]

Time to move to ReVanced/revanced-manager#675 and ReVanced/revanced-patches#1580. Thanks!