Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate deprecation code && code cleanup #708

Merged
merged 3 commits into from
Feb 19, 2023

Conversation

validcube
Copy link
Member

@validcube validcube commented Feb 18, 2023

🧹 Task Force Cleanup

Improve the readability of the code.

Migrate deprecated text style
Migrate toggleableActiveColor to individual theme
Don't use 'BuildContext's across async gaps

These changes were applied as suggested by the Flutter migration guide

flutter analyze

image

@validcube validcube requested a review from Ushie February 18, 2023 06:02
@validcube validcube merged commit 4496f39 into ReVanced:dev Feb 19, 2023
validcube added a commit to validcube/revanced-manager that referenced this pull request Feb 20, 2023
Fixes all issues in `flutter analyze`.
<Reviewed>

Commits:
* chore: migrate deprecated text style

* chore: migrate `toggleableActiveColor` to individual theme

* chore: don't use 'BuildContext's across async gaps
validcube added a commit to validcube/revanced-manager that referenced this pull request Feb 20, 2023
Fixes all issues in `flutter analyze`.
<Reviewed>

Commits:
* chore: migrate deprecated text style

* chore: migrate `toggleableActiveColor` to individual theme

* chore: don't use 'BuildContext's across async gaps
validcube added a commit to validcube/revanced-manager that referenced this pull request Feb 27, 2023
Fixes all issues in `flutter analyze`.
<Reviewed>

Commits:
* chore: migrate deprecated text style

* chore: migrate `toggleableActiveColor` to individual theme

* chore: don't use 'BuildContext's across async gaps
@validcube validcube deleted the migrate_deprecation branch March 27, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants