chore: Sync translations #2005

revanced-bot · 2024-06-24T16:55:47Z

Sync translations from crowdin.com/project/revanced

LisoUseInAIKyrios · 2024-07-09T19:56:42Z

chore: Remove empty values from JSON

Just an FYI as this doesn't matter since everything is working, but empty strings can be removed during the Crowdin export by using a regex filter. The Crowdin project now has a regex file processor plugin and it avoids the need of running extra code here on GitHub.

Ushie · 2024-07-09T20:00:51Z

With the upcoming switch to Jetpack Compose, we won't need either solutions

But thank you for the piece of info! might deprecate the composite action

validcube

🔥 Translation error

validcube · 2024-07-22T06:00:44Z

assets/i18n/strings_fa_IR.i18n.json

@@ -1,18 +1,18 @@
 {
  "okButton": "تأیید",
  "cancelButton": "انصراف",
+  "dismissButton": "Dismiss\nنادیده گرفتن",


Seems to be faulty translation

validcube · 2024-07-22T06:01:28Z

assets/i18n/strings_fil_PH.i18n.json

-    "selectFromStorageButton": "Pumili ka galing sa storage"
+    "selectFromStorageButton": "Pumili ka galing sa storage",
+    "errorMessage": "Hindi magamit ang napiling aplikasyon",
+    "downloadToast": "Download function is not available yet",


Not actually translated

validcube · 2024-07-22T06:01:33Z

assets/i18n/strings_fil_PH.i18n.json

  },
  "patchSelectorCard": {
+    "widgetTitle": "Pumili ng mga pantapal",
+    "widgetTitleSelected": "Napiling mga pantapal",
+    "widgetSubtitle": "Select an application first",


Not actually translated

validcube · 2024-07-22T06:02:28Z

assets/i18n/strings_hi_IN.i18n.json

    "orgPatchesLabel": "पैच संगठन",
    "sourcesPatchesLabel": "पैच स्रोत",
    "orgIntegrationsLabel": "एकीकरण संगठन",
    "contributorsLabel": "योगदान कर्ता",
    "contributorsHint": "ReVanced के योगदानकर्ताओ की सूची",
+    "autoUpdatePatchesLabel": "Auto update patches",


Not actually translated?

validcube · 2024-07-22T06:05:22Z

assets/i18n/strings_te_IN.i18n.json

+    "installButton": "స్థాపించు",
+    "openButton": "తెరువు",
+    "notificationTitle": "రీవాన్సడ్ మేనేజర్ పాచ్ చేస్తుంది",
+    "notificationText": "Tap to return to the installer"


Not actually translated

validcube · 2024-07-22T06:05:30Z

assets/i18n/strings_te_IN.i18n.json

+    "noneChip": "ఏదీ కాదు"
+  },
+  "patchOptionsView": {
+    "saveOptions": "Save"


Not actually translated

All of these should now be fixed. Most were untranslated data that got into the 'translation memory' at a prior time.

LisoUseInAIKyrios · 2024-07-22T15:11:15Z

Should "Manager" be translated, or should the original English be used everywhere?

If it should be English, string like this could be set to hidden prevent translating:

oSumAtrIX · 2024-07-22T15:12:59Z

This should probably say ReVanced Manager. What's the reason for the merge conflicts?

LisoUseInAIKyrios · 2024-07-22T15:15:46Z

What about "Patcher", "Patch", "Patched", and "Patches"? Use English, or translate?

Seems like translating might be correct, since the words are used as both a noun, as a verb, and also in the middle of sentences. Using English "Patched" for all languages might be confusing.

oSumAtrIX · 2024-07-22T15:21:05Z

I think they say Manager and Patcher because they are not referring to the products but to the applications. ReVanced Patcher is a patcher, and ReVanced Manager is a manager. In that case I believe Manager and Patcher make sense but should be appropriately cased when used in sentences too.

oSumAtrIX · 2024-07-22T15:24:18Z

To answer your initial question, yes, they should be translated since they are regular words.

LisoUseInAIKyrios · 2024-07-22T15:26:43Z

what about Manager? That is the app name (which is not translated, and shows up in the Launcher as "ReVanced Manager"). Use English for that?

And just to make things clear, "Patcher" and all variants (Patches, Patched) should be translated everywhere?

oSumAtrIX · 2024-07-22T15:28:40Z

The app name refers to the product. You would not translate your name LisoUseInAIKyrios. Similarly, you would not translate ReVanced Manager. If in the app instead, it refers to the application with "manager", so not to the product with its name, then it should be translated, because it is a regular word and not a name.

And just to make things clear, "Patcher" and all variants (Patches, Patched) should be translated everywhere?

Yes, the patcher is the application named "ReVanced Patcher".

validcube · 2024-07-29T17:13:03Z

Should "Manager" be translated, or should the original English be used everywhere?

If it should be English, string like this could be set to hidden prevent translating: Manager:

The string was supposed to be delete a long time ago, I have programmatically removed them here: b649c45

Thanks

validcube · 2024-07-29T18:01:59Z

Merging this, I hope Slang doesn't implod

validcube · 2024-07-29T18:14:07Z

chore: Remove empty values from JSON

Just an FYI as this doesn't matter since everything is working, but empty strings can be removed during the Crowdin export by using a regex filter. The Crowdin project now has a regex file processor plugin and it avoids the need of running extra code here on GitHub.

I'm sure the reason it was added is that our current tool decided to not work with empty JSON keys which is a pain for us.

github-actions bot force-pushed the feat/translations branch 3 times, most recently from 0160430 to 99c21e1 Compare July 1, 2024 12:04

github-actions bot force-pushed the feat/translations branch from 59af03e to 81e4d80 Compare July 8, 2024 12:04

github-actions bot force-pushed the feat/translations branch 2 times, most recently from 3244d1e to 0f20241 Compare July 15, 2024 12:05

github-actions bot force-pushed the feat/translations branch from 28454bd to 7545bae Compare July 22, 2024 05:58

validcube requested changes Jul 22, 2024

View reviewed changes

github-actions bot force-pushed the feat/translations branch from 538ea9d to 939ece2 Compare July 22, 2024 12:04

github-actions bot force-pushed the feat/translations branch 4 times, most recently from 5a37147 to 30d5a3c Compare July 29, 2024 17:13

github-actions bot force-pushed the feat/translations branch from 9afdeed to 8cd0a76 Compare July 29, 2024 17:17

chore: Sync translations

2b4c065

github-actions bot force-pushed the feat/translations branch from 8cd0a76 to 2b4c065 Compare July 29, 2024 17:23

validcube self-requested a review July 29, 2024 18:00

validcube merged commit 5690adc into dev Jul 29, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Sync translations #2005

chore: Sync translations #2005

revanced-bot commented Jun 24, 2024

LisoUseInAIKyrios commented Jul 9, 2024

Ushie commented Jul 9, 2024 •

edited

Loading

validcube left a comment

validcube Jul 22, 2024

validcube Jul 22, 2024

validcube Jul 22, 2024

validcube Jul 22, 2024

validcube Jul 22, 2024

validcube Jul 22, 2024

LisoUseInAIKyrios Jul 22, 2024

LisoUseInAIKyrios commented Jul 22, 2024

oSumAtrIX commented Jul 22, 2024 •

edited

Loading

LisoUseInAIKyrios commented Jul 22, 2024 •

edited

Loading

oSumAtrIX commented Jul 22, 2024

oSumAtrIX commented Jul 22, 2024

LisoUseInAIKyrios commented Jul 22, 2024

oSumAtrIX commented Jul 22, 2024 •

edited

Loading

validcube commented Jul 29, 2024 •

edited

Loading

validcube commented Jul 29, 2024

validcube commented Jul 29, 2024

chore: Sync translations #2005

chore: Sync translations #2005

Conversation

revanced-bot commented Jun 24, 2024

LisoUseInAIKyrios commented Jul 9, 2024

Ushie commented Jul 9, 2024 • edited Loading

validcube left a comment

Choose a reason for hiding this comment

validcube Jul 22, 2024

Choose a reason for hiding this comment

validcube Jul 22, 2024

Choose a reason for hiding this comment

validcube Jul 22, 2024

Choose a reason for hiding this comment

validcube Jul 22, 2024

Choose a reason for hiding this comment

validcube Jul 22, 2024

Choose a reason for hiding this comment

validcube Jul 22, 2024

Choose a reason for hiding this comment

LisoUseInAIKyrios Jul 22, 2024

Choose a reason for hiding this comment

LisoUseInAIKyrios commented Jul 22, 2024

oSumAtrIX commented Jul 22, 2024 • edited Loading

LisoUseInAIKyrios commented Jul 22, 2024 • edited Loading

oSumAtrIX commented Jul 22, 2024

oSumAtrIX commented Jul 22, 2024

LisoUseInAIKyrios commented Jul 22, 2024

oSumAtrIX commented Jul 22, 2024 • edited Loading

validcube commented Jul 29, 2024 • edited Loading

validcube commented Jul 29, 2024

validcube commented Jul 29, 2024

Ushie commented Jul 9, 2024 •

edited

Loading

oSumAtrIX commented Jul 22, 2024 •

edited

Loading

LisoUseInAIKyrios commented Jul 22, 2024 •

edited

Loading

oSumAtrIX commented Jul 22, 2024 •

edited

Loading

validcube commented Jul 29, 2024 •

edited

Loading