build: Enable ProGuard #1650
Merged
build: Enable ProGuard #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oSumAtrIX
reviewed
Jan 23, 2024
oSumAtrIX
requested changes
Jan 25, 2024
TheAabedKhan
force-pushed
the
dev
branch
2 times, most recently
from
4b37202 to
f8ee197
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
## Features * Improve consistency on language selector ([Pun Butrach](b2119ce)) ## Code Refactoring * Check-in pubspec.lock ([Pun Butrach](5a24911)) ## Build System * Bump Gradle to v8.6 ([Pun Butrach](f57898a)) * Enable ProGuard (#1650) ([kitadai31](b754a04)) ## Continuous Integration * **build:** Upload build artifact ([Pun Butrach](e0c750d)) ## Chores * Update .gitignore ([Pun Butrach](0ec6897))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable ProGuard like compose manager.
The size of release APK: 45.7MB -> 39.9MB (5.8MB reduced)
Motivation
5.8MB is not a small change.
Each version of ReVanced Manager is being downloaded 100,000-300,000 times.
5.8MB * 200,000 times = 1,160,000MB ≒ 1.1TB
So, this reduces 1.1TB of GItHub's traffic from each new versions.
Therefore, if you are planning to continue to release Flutter manager, I think this is effective.
Other
Also, this PR disables Jetifier.
because all dependent libraries support AndroidX. (checked by
gradlew checkJetifier)This solves this build error:
Test
I tested all features of ReVanced Manager and checked works correctly.
This change was already introduced on my fork ReVanced Manager a month ago, which is 2500 downloads, and any problems are not reported.