Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve Split APK warning readability #1625

Merged
merged 4 commits into from
Jan 22, 2024
+1 −1
Merged

fix: Improve Split APK warning readability #1625

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb1b0da
chore: merge `dev` to `main` (#1573)
oSumAtrIX Dec 23, 2023
38cdeb2
Changed featureNotAvailableText to new shortened and simplified text
otahir-21 Jan 8, 2024
7875f57
Changed featureNotAvailableText to shortened and simplified text
otahir-21 Jan 8, 2024
056912c
Update assets/i18n/en_US.json
validcube Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/i18n/en_US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
"requireSuggestedAppVersionDialogText": "The version of the app you have selected does not match the suggested version. Please select the app that matches the suggested version.\n\nSelected version: v{selected}\nSuggested version: v{suggested}\n\nTo proceed anyway, disable \"Require suggested app version\" in the settings.",

"featureNotAvailable": "Feature not implemented",
"featureNotAvailableText": "This application is a split APK and cannot be selected. Unfortunately, this feature is only available for rooted users at the moment. However, you can still install the application by selecting its APK files from your device's storage instead"
"featureNotAvailableText": "This application is a split APK and can only be patched with root permissions at the moment. Obtain a full APK and select it from storage or install it and select it regularly."
Copy link
Member

@oSumAtrIX oSumAtrIX Jan 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed correctness and shortened solution. Installing and patching would require uninstalling.

Suggested change
"featureNotAvailableText": "This application is a split APK and can only be patched with root permissions at the moment. Obtain a full APK and select it from storage or install it and select it regularly."
"featureNotAvailableText": "This app is a split APK and can only be patched and installed reliably by mounting with root permissions. However, you can patch and install a full APK by selecting it from storage."

},
"patchesSelectorView": {
"viewTitle": "Select patches",
Expand Down