Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Merge dev to main #1611

Merged
merged 100 commits into from
Mar 5, 2024
Merged

chore: Merge dev to main #1611

merged 100 commits into from
Mar 5, 2024

Conversation

Ushie
Copy link
Member

@Ushie Ushie commented Dec 31, 2023 •
edited by oSumAtrIX
Loading

Fixes #1325, closes #1629, fixes #530

@Ushie Ushie linked an issue Jan 9, 2024 that may be closed by this pull request
bug: KernelSU compatibility #1592
Closed
4 tasks
@BenjaminHalko @Ushie @validcube
feat: add haptic feedback (#1459)
7911459 
Co-authored-by: Ushie <[email protected]>
Co-authored-by: Pun Butrach <[email protected]>
validcube
validcube previously requested changes Jan 16, 2024
View reviewed changes
Copy link
Member

@validcube validcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this to block merge for now

@validcube validcube linked an issue Jan 21, 2024 that may be closed by this pull request
[BUG] Redundant Cancel button on Installation failure #1600
Closed
@validcube validcube linked an issue Jan 21, 2024 that may be closed by this pull request
bug(patch option): main text only conformed to dark theme #1584
Closed
validcube
validcube previously approved these changes Jan 21, 2024
View reviewed changes
Copy link
Member

@validcube validcube left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗿 Tested & Approve:

Warning

New bug arose during testing:

validcube
validcube approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@validcube validcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥞 Should be ready to merge.

@validcube
Copy link
Member

@validcube Here is a secret named REPOSITORY_PUSH_ACCESS

Hm, the secret appear to be empty, could you verify that it's correctly set?

https://github.com/ReVanced/revanced-manager/actions/runs/8135888633/job/22231203031

@oSumAtrIX
Copy link
Member

@validcube Try now

@oSumAtrIX oSumAtrIX linked an issue Mar 4, 2024 that may be closed by this pull request
Export APK button doesn't respond after Opening installed app #1537
Closed
4 tasks
semantic-release-bot and others added 2 commits March 4, 2024 12:51
@semantic-release-bot
chore(release): 1.19.0-dev.19 [skip ci]
4fc913e 
# [1.19.0-dev.19](v1.19.0-dev.18...v1.19.0-dev.19) (2024-03-04)

### Bug Fixes

* Fix patched APKs exports after installation ([1200360](1200360))

### Features

* Use more appropriate progress values ([2d7026a](2d7026a))
@oSumAtrIX
build: Bump dependencies
c5e04cc
@validcube
Copy link
Member

This release, will completely obliterate the changelog.

oSumAtrIX
oSumAtrIX requested changes Mar 4, 2024
View reviewed changes
Copy link
Member

@oSumAtrIX oSumAtrIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be an issue ReVanced/revanced-cli#309 (comment)

oSumAtrIX and others added 2 commits March 4, 2024 15:48
@oSumAtrIX
fix: Bump dependencies to support BCS keystore
6ec6546
@semantic-release-bot
chore(release): 1.19.0-dev.20 [skip ci]
4ca7b8a 
# [1.19.0-dev.20](v1.19.0-dev.19...v1.19.0-dev.20) (2024-03-04)

### Bug Fixes

* Bump dependencies to support BCS keystore ([6ec6546](6ec6546))
@validcube
Copy link
Member

OH WE'RE PUSHING NOW, REAL MEN TEST IN PRODUCTION

validcube
validcube requested changes Mar 4, 2024
View reviewed changes
Copy link
Member

@validcube validcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, not yet, wait for ushie to push some stuff first

@Ushie
Copy link
Member Author

Ushie commented Mar 4, 2024

If you merge, you're going to find your pet hidden in a funny hole at a random north korea graveyard

@validcube
Copy link
Member

If you merge, you're going to find your pet hidden in a funny hole at a random north korea graveyard

Not the cat :(

Ushie and others added 2 commits March 5, 2024 03:04
@Ushie
feat: Display current app language at the top of the list
aa0575a
@semantic-release-bot
chore(release): 1.19.0-dev.21 [skip ci]
bc83a39 
# [1.19.0-dev.21](v1.19.0-dev.20...v1.19.0-dev.21) (2024-03-05)

### Features

* Display current app language at the top of the list ([aa0575a](aa0575a))
@Ushie
Copy link
Member Author

Ushie commented Mar 5, 2024

I don't have enough experience with flutter UI to solve the ongoing UI issues caused by longer strings, I'll merge this for now to get the important fixes in and assign someone else to it

@validcube validcube merged commit cea4c6c into main Mar 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAabedKhan TheAabedKhan TheAabedKhan left review comments

@validcube validcube validcube requested changes

@oSumAtrIX oSumAtrIX oSumAtrIX approved these changes

@BenjaminHalko BenjaminHalko Awaiting requested review from BenjaminHalko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
9 participants
@Ushie @validcube @oSumAtrIX @TheAabedKhan @BenjaminHalko @otahir-21 @semantic-release-bot @kitadai31 @erayerdin