-
-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Build pre-release versions #1606
Conversation
Testing on my own fork seems to be successful. |
Does the built APK match the bumped version? Looking into this, it may be one version behind. |
I think you may be correct... |
@PalmDevs What were the complications we had when we wanted semantic releases? |
We can run semantic-release twice with different configs. The first time is run before building which is to bump pubspec.yaml. The second time is to finally upload. |
Same issue we currently have at the moment. |
How does this plan to handle version code and version name bumps? Version names are decided by semantic release, but we went with a stupid design for version code and I don't think it incorporates dev version, and we also need to answer the question of when does the version code bumps happen? |
It handles version names as is, version code will be incremented by one from what we currently have.
The plugin in this PR bumps by one from what we currently have. Development versions will always be ahead or equal in version code unless someone decides to push to the main branch which we have restrictions for.
Before the build process:
|
Every single build is gonna bump by 1, so dev 1 and dev 2 both bump the version codes I assume? |
Yep, every trigger/build = 1 bump |
This comment was marked as off-topic.
This comment was marked as off-topic.
Ok I think it works now! |
Uses semantic release to build prereleases from dev. (it is now used when making non-pre-release builds as well)
TODO: