Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Build pre-release versions #1606

Merged
merged 9 commits into from
Jan 22, 2024
Merged

ci: Build pre-release versions #1606

merged 9 commits into from
Jan 22, 2024

Conversation

BenjaminHalko
Copy link
Member

@BenjaminHalko BenjaminHalko commented Dec 29, 2023

Uses semantic release to build prereleases from dev. (it is now used when making non-pre-release builds as well)

TODO:

  • Testing

@BenjaminHalko BenjaminHalko marked this pull request as ready for review December 29, 2023 22:01
@BenjaminHalko
Copy link
Member Author

Testing on my own fork seems to be successful.

@BenjaminHalko BenjaminHalko changed the title feat: Pre-releases ci(build): Pre-releases Dec 29, 2023
@PalmDevs
Copy link
Member

Does the built APK match the bumped version? Looking into this, it may be one version behind.

@BenjaminHalko
Copy link
Member Author

I think you may be correct... flutter build apk should be a part of .releaserc and not the workflow, so that it gets executed after the version bump.

@Ushie
Copy link
Member

Ushie commented Dec 30, 2023

@PalmDevs What were the complications we had when we wanted semantic releases?

@PalmDevs
Copy link
Member

I think you may be correct... flutter build apk should be a part of .releaserc and not the workflow, so that it gets executed after the version bump.

We can run semantic-release twice with different configs. The first time is run before building which is to bump pubspec.yaml. The second time is to finally upload.

@PalmDevs
Copy link
Member

@PalmDevs What were the complications we had when we wanted semantic releases?

Same issue we currently have at the moment.

@Ushie
Copy link
Member

Ushie commented Dec 30, 2023

How does this plan to handle version code and version name bumps?

Version names are decided by semantic release, but we went with a stupid design for version code and I don't think it incorporates dev version, and we also need to answer the question of when does the version code bumps happen?

@PalmDevs
Copy link
Member

PalmDevs commented Dec 30, 2023

How does this plan to handle version code and version name bumps?

It handles version names as is, version code will be incremented by one from what we currently have.

Version names are decided by semantic release, but we went with a stupid design for version code and I don't think it incorporates dev version

The plugin in this PR bumps by one from what we currently have. Development versions will always be ahead or equal in version code unless someone decides to push to the main branch which we have restrictions for.

We also need to answer the question of when does the version code bumps happen?

Before the build process:

  1. Bump everything and commit (via 1st semantic-release config)
  2. Build APK (via shell)
  3. Upload, generate changelogs, and release (via 2nd semantic-release config)

@Ushie
Copy link
Member

Ushie commented Dec 30, 2023

The plugin in this PR bumps by one from what we currently have. Development versions will always be ahead or equal in version code unless someone decides to push to the main branch which we have restrictions for.

Every single build is gonna bump by 1, so dev 1 and dev 2 both bump the version codes I assume?

@PalmDevs
Copy link
Member

The plugin in this PR bumps by one from what we currently have. Development versions will always be ahead or equal in version code unless someone decides to push to the main branch which we have restrictions for.

Every single build is gonna bump by 1, so dev 1 and dev 2 both bump the version codes I assume?

Yep, every trigger/build = 1 bump

@oSumAtrIX

This comment was marked as off-topic.

@BenjaminHalko
Copy link
Member Author

Ok I think it works now!

.releaserc.bump.json Outdated Show resolved Hide resolved
@oSumAtrIX oSumAtrIX removed the request for review from validcube January 14, 2024 02:46
@oSumAtrIX oSumAtrIX changed the title ci(build): Pre-releases ci(build): Build pre-release versions Jan 22, 2024
@oSumAtrIX oSumAtrIX changed the title ci(build): Build pre-release versions ci: Build pre-release versions Jan 22, 2024
@oSumAtrIX oSumAtrIX merged commit ec2c2d8 into dev Jan 22, 2024
1 check passed
@oSumAtrIX oSumAtrIX deleted the feat/prerelease branch January 22, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants